On 02/04/2010, at 6:45 AM, Denys Vlasenko wrote:

> On Wednesday 31 March 2010 03:49, Steve Bennett wrote:
>> Ping. Any interest in this patch?
>> 
>> On 22/03/2010, at 7:46 AM, Steve Bennett wrote:
>> 
>>> 
>>> On 22/03/2010, at 7:49 AM, Bernhard Reutner-Fischer wrote:
>>> 
>>>> On Fri, Mar 19, 2010 at 10:15:11AM +1000, Steve Bennett wrote:
>>>>> This patch allows mdev to omit creation of device nodes
>>>> 
>>>> I'd go for '!' and your doc hunk lacks '"prevent" creation' or "omit".
>>>> 
>>> 
>>> '!' probably makes slightly more sense.
>>> How's this (with docs made clearer too)?
> 
> 
> This treats creation actions as deletions too - it will
> delete the device node if it exist. This is confusing.

Possibly. What does delete even mean when the "create" action
is to not create the device node?

> 
> Maybe you should set major = -1 instead?

That is probably fine too.
> 
> And why do you disallow command in this case?
> It might be useful.

Possibly. It seemed confusing to me to run a command
on create/delete of a device node which is just being
ignored. Can you think of a real use case, or do you
just like the symmetry of it?

> 
> -- 
> vda
> 


Steve
--
µWeb: Embedded Web Framework - http://uweb.workware.net.au/

_______________________________________________
busybox mailing list
[email protected]
http://lists.busybox.net/mailman/listinfo/busybox

Reply via email to