On Fri, 2010-05-14 at 15:41 -0500, Rob Landley wrote: > On Thursday 13 May 2010 18:05:53 Peter Tyser wrote: > > Using 'read' without a variable is not supported in many shells. Lines > > such as 'while read; do' in gen_build_files.sh would result in build > > failures when using sh or dash as an interpreter: > > Simple fix: say #!/bin/bash at the top of all shell scripts, always.
With the exception of fix_ws.sh, all other shell scripts in scripts/ use /bin/sh. I had assumed this was intentional? Unless there is a specific bashism that makes gen_build_files.sh much cleaner/better/etc, why not keep it portable? I also personally prefer explicitly specifying a variable for 'read' instead of using the "magical" REPLY variable. Best, Peter _______________________________________________ busybox mailing list busybox@busybox.net http://lists.busybox.net/mailman/listinfo/busybox
