On Wed, Jun 01, 2011 at 01:36:20PM -0700, Dan Fandrich wrote: > +#if defined(__GLIBC__) && (__GLIBC__ < 2 || __GLIBC_MINOR__ < 1) > +# undef HAVE_NET_ETHERNET_H > +#endif
This is nonsense. glibc older than 2.1 is definitely not usable. > -#if (defined(__GLIBC__) && __GLIBC__ >= 2 && __GLIBC_MINOR__ >= 1) || > defined(_NEWLIB_VERSION) > +#ifdef HAVE_NET_ETHERNET_H > # include <netpacket/packet.h> > # include <net/ethernet.h> > #else I suspect this might break support for anything that lacks netpacket/packet.h, including musl. In general it's a very bad idea to use the same HAVE_* macro for two completely separate headers. Perhaps other similar issues... Rich _______________________________________________ busybox mailing list [email protected] http://lists.busybox.net/mailman/listinfo/busybox
