On Tue, Feb 17, 2015 at 7:21 PM, Xabier Oneca -- xOneca <[email protected]> wrote: > 2015-02-15 14:58 GMT+01:00 Denys Vlasenko <[email protected]>: >> On Sun, Feb 15, 2015 at 8:03 AM, Explorer <[email protected]> wrote: >>> From 60836c395e0d1a71da573175fde410cc69e67b78 Mon Sep 17 00:00:00 2001 >>> From: Explorer09 <[email protected]> >>> Date: Sun, 15 Feb 2015 14:50:34 +0800 >>> Subject: [PATCH] CONFIG_FTPD should select FEATURE_LS_TIMESTAMPS >>> >>> This adds a 'select' line that if ftpd and ls are both enabled, ls >>> timestamps >>> feature will always be selected. >>> >>> Without this line, FEATURE_LS_TIMESTAMPS will still be enabled internally >>> due >>> to the macro lines like this in ls.c: >>> #if ENABLE_FTPD >>> # undef CONFIG_FEATURE_LS_TIMESTAMPS >>> ... >>> # define CONFIG_FEATURE_LS_TIMESTAMPS 1 >>> ... >>> #endif >>> >>> I would like to have kconfig handle the dependency and letting it explicit >>> to >>> builders. >>> >>> Signed-off-by: Kang-che Sung <explorer09-at-gmail.com> >> >> I don't think this change is useful. > > You refer to the fact that the config was select'ed, but the code was > not cleaned, don't you?
I don't see how is this change useful. I can see why it can be _harmful_. Imagine that ftpd.c is changed so that it no longer requires FEATURE_LS_TIMESTAMPS. There are high changes that the "select" statement will not be removed (since it is not in that file, and it's not obvious that it is related to it), and as such will become erroneous. _______________________________________________ busybox mailing list [email protected] http://lists.busybox.net/mailman/listinfo/busybox
