2015-02-17 21:47 GMT+01:00 Denys Vlasenko <[email protected]>: > On Tue, Feb 17, 2015 at 7:21 PM, Xabier Oneca -- xOneca > <[email protected]> wrote: >> 2015-02-15 14:58 GMT+01:00 Denys Vlasenko <[email protected]>: >>> >>> I don't think this change is useful. >> >> You refer to the fact that the config was select'ed, but the code was >> not cleaned, don't you? > > I don't see how is this change useful. > > I can see why it can be _harmful_. > > Imagine that ftpd.c is changed so that it no longer requires > FEATURE_LS_TIMESTAMPS. There are high changes that the "select" > statement will not be removed (since it is not in that file, > and it's not obvious that it is related to it), > and as such will become erroneous.
The code is about a feature of FTPD. Now, the code is in LS file. The proposed change moves that config dependency to the Config.src file, where it belongs. Well, it could/should even be moved to ftpd.c, in a //config: comment. I am not saying you should approve sent patch (I wouldn't), but It makes sense the change OP proposed. Cheers, Xabier Oneca_,,_ _______________________________________________ busybox mailing list [email protected] http://lists.busybox.net/mailman/listinfo/busybox
