Here are the bloat-o-meter results: function old new delta .rodata 166664 166882 +218 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 1/0 up/down: 218/0) Total: 218 bytes This patch saves 42 bytes over the previous patch. I'm using GCC 4.8.5 on CentOS 7; however, the results are the same for GGC 7.3.1. There is a 0 byte difference between the individual field copy and the memcmp version.
On Tue, Oct 16, 2018 at 2:19 AM Bernhard Reutner-Fischer < [email protected]> wrote: > On 15 October 2018 22:54:17 CEST, Brandon Enochs <[email protected]> > wrote: > >Here's the hopefully complete patch: > > >> > >> Was the memcpy+xstrdup better than the individual stores? Which > >version of > >> gcc did you try? > > You didn't answer this. > Please send git format-patch patches, including a Signed-off-by statement > to clarify copyrights. > And please include full bloat-o-meter output (ideally mentioning the > compiler, linker, assembler used) for reference. > > TIA, >
_______________________________________________ busybox mailing list [email protected] http://lists.busybox.net/mailman/listinfo/busybox
