Hello Dominik,
I have been able to check your two patches. They are working fine. (I think
I was also figured what my problems were. Thank you for you support.)
I would like to make a small suggestion regarding the tests. Below is diff
between wait8.tests~ (your version) and wait8.tests (my suggestion). It
simply about making clear what is tested. That's all.
$ diff wait8.tests~ wait8.tests
8c8
< echo Test1
---
> echo "Test1 (wait with zero exit status of bg process)"
17c17
< echo Test2
---
> echo "Test2 (wait with non-zero exit status of bg process)"
33c33
< echo Test3
---
> echo "Test3 (pipeline wait time)"
45a46
> echo "Test4 (wait returns exit status plus signal)"
53a55
> echo "Test5 (exit code 127 if nothing to wait for)"
--
Building on your patches I would now look into adding bash's `-p pid`
option. To keep code changes minimal I would try to add a global variable
to hold the pid which is set in waitone() and read in the calling
waitcmd(). Or is anybody already working on this?
Regards
Wolfgang
_______________________________________________
busybox mailing list
[email protected]
https://lists.busybox.net/mailman/listinfo/busybox
