Hi Wolfgang,
Wolfgang Zekoll wrote on Tue, Nov 11, 2025 at 03:22:26PM +0000: > I have been able to check your two patches. They are working fine. (I think > I was also figured what my problems were. Thank you for you support.) Thanks for testing! > I would like to make a small suggestion regarding the tests. Below is diff > between wait8.tests~ (your version) and wait8.tests (my suggestion). It > simply about making clear what is tested. That's all. This makes sense, I'll send a v2 with this and your Tested-by. > Building on your patches I would now look into adding bash's `-p pid` > option. To keep code changes minimal I would try to add a global variable to > hold the pid which is set in waitone() and read in the calling waitcmd(). Or > is anybody already working on this? I can't talk for anyone else, but I'm not. Just a note on globals, afaiu busybox tries to limit the use of globals in applets as they affect all applets, but it looks like you can use the G_* global structs -- this could go in G_misc next to backgndpid? Either way I think it could be useful -- wait -n is pretty hard to use correctly without info about which process terminated, so will be happy to review your patch when it's ready. -- Dominique Martinet | Asmadeus _______________________________________________ busybox mailing list [email protected] https://lists.busybox.net/mailman/listinfo/busybox
