[
https://issues.apache.org/jira/browse/BVAL-62?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12871566#action_12871566
]
Mark Struberg commented on BVAL-62:
-----------------------------------
Sorry, but I'm not a huge fan of reverting a commit _without_ any discussion.
I checked out the latest spec and read the following:
4.4.4.1
> By default, providers are resolved using the Service Provider pattern
> described in
> http://java.sun.com/j2se/1.5.0/docs/guide/jar/jar.html#Service%20Provider.
> Bean Validation providers must supply a
> service provider configuration file by creating a text file
> javax.validation.spi.ValidationProvider and placing
> it in the META-INF/services directory of one of its jar files. The content of
> the file should contain the name of the
> provider implementation class of the javax.validation.spi.ValidationProvider
> interface.
But we internally currently dont use the java.util.ServiceLoader but do a
cl.getResources(SPI_CFG);
instead in DefaultValidationProviderResolver#getValidationProviders()
This is imo a bug in our impl!
See here for how to use the ServiceLoader mechanism properly:
https://svn.apache.org/repos/asf/openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/plugins/PluginLoader.java
LieGrue,
strub
> add missing ASL headers
> -----------------------
>
> Key: BVAL-62
> URL: https://issues.apache.org/jira/browse/BVAL-62
> Project: BeanValidation
> Issue Type: Bug
> Affects Versions: 0.1-incubating
> Reporter: Mark Struberg
> Assignee: Mark Struberg
> Fix For: 0.1-incubating
>
>
> currently RAT reports a few files without license headers.
> This must get fixed
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
