Hi Elliot, Elliot Murphy wrote: > I see that Sabin has been active in trying to fix the DBus problems > lately, that is great. I have looked at the patches for this bug: > https://bugs.edge.launchpad.net/bzr-gtk/+bug/235668 > > And also what has already been merged for this bug: > https://bugs.edge.launchpad.net/bzr/+bug/107169 > > However, Guilhem reports in the last comment for bug 107169 that he > still has a problem, because the code: > > bus = dbus.SessionBus() > > is raising DBusException: > org.freedesktop.DBus.Error.Spawn.ExecFailed: Failed to execute > dbus-launch to autolaunch D-Bus session. > > Ultimately, the only thing that we do if we have DBus problems in > seahorse.py is to proceed without seahorse. It is much more useful > for people to have visualize without seahorse than it is to crash. > So, I'm proposing that we make this much more resilient with this > very simple patch. > > One possible improvement would be to log any unexpected exceptions > (anything that was not already translated to ImportError, but I'm > much more concerned with getting visualize to work again. We really should just be deciding in seahorse.py what specific exceptions are reasons to not use seahorse. If we really have to, we can catch all DBusExceptions when creating the session bus.
However, catching all exceptions is going to hide a lot of valid errors and that will be confusing for users that do want to use the seahorse support. bb:resubmit Cheers, Jelmer -- bzr-gtk mailing list [email protected] Modify settings or unsubscribe at: https://lists.canonical.com/mailman/listinfo/bzr-gtk
