Am Samstag, den 12.07.2008, 03:42 -0600 schrieb Scott Scriven: > * Scott Scriven <[EMAIL PROTECTED]> wrote: > > The changes are available in my branch: > > > > lp:~toykeeper/bzr-gtk/bzr-vis-enhancements/ > > And, if people prefer a merge directive, it's attached. > > A few changes are included, but they're all related: > > - Added an optional diff panel to vis. > - Made vis remember its window size, panel sizes, and toolbar > state. > - Removed some redundant screen redrawing vis. > - Fixed overflowing labels/buttons in vis. I like this in general. I would prefer to see the diff panel below the revision metadata and file list, but I can live with the current patch being merged.
Some other things I think *should* be fixed before this can be merged: - Please don't use hasattr() since it swallows exceptions (see bzr's HACKING for details). - Please make not showing diffs the default (for consistency with older versions) bb:tweak Cheers, Jelmer -- Jelmer Vernooij <[EMAIL PROTECTED]> - http://samba.org/~jelmer/ Jabber: [EMAIL PROTECTED] -- bzr-gtk mailing list [email protected] Modify settings or unsubscribe at: https://lists.canonical.com/mailman/listinfo/bzr-gtk
