[ https://issues.apache.org/jira/browse/XERCESC-2179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16967077#comment-16967077 ]
Scott Cantor commented on XERCESC-2179: --------------------------------------- A release is likely to take months, a week doesn't matter. If the submitted patch exhibits changed behavior then the logical step will be to do a detailed diff of what it's changing and then examine each Registry API call for anomalous inputs to make sure there isn't a stray call that isn't constructed like the others. Adjusting the declared types as part of that review will help clean up the code. I don't think adding room for nulls is specifically involved, but I would be concerned that there may be code paths not detecting or handling the error codes indicating the buffers are insufficient, perhaps. But as Albert said, that shouldn't be the case for DWORD-based registry values. > access violation in win32transservice.cpp with 64 bit compile > ------------------------------------------------------------- > > Key: XERCESC-2179 > URL: https://issues.apache.org/jira/browse/XERCESC-2179 > Project: Xerces-C++ > Issue Type: Bug > Components: DOM > Affects Versions: 3.2.2 > Reporter: martin goodall > Assignee: Alberto Massari > Priority: Blocker > Fix For: 3.2.3 > > Attachments: Win32TransService.cpp > > > calls to ::Reg... to get registry info are passing in stack variables that > are 8 bytes long into functions that overwrite 16 bytes, causing memory > overwrite and very random segs. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: c-dev-unsubscr...@xerces.apache.org For additional commands, e-mail: c-dev-h...@xerces.apache.org