On 24 October 2011 09:53, Max Bolingbroke <batterseapo...@hotmail.com> wrote: > On 24 October 2011 07:27, Bas van Dijk <v.dijk....@gmail.com> wrote: >> I like the idea Max. Attached is the patch which implements it. >> There's only one issue: In doPackageRender I can't make the >> distinction between normal and candidate packages so I can't serve the >> correct logo url. So currently candidate logo's are broken. Do you >> have an idea to make them work again? > > I see. It looks like doCandidateRender fixes up the result of > doPackageRender by modifying the rendPkgUri. What this suggests to me > is that we don't want to store the full logo URI but instead define a > rendLogoUri :: PackageRender -> Maybe String which constructs the URL > using the rendPkgUri. > > I've modified your patch accordingly (attached) but haven't tested it. > > Max >
Thanks Max, it works on my site. Bas _______________________________________________ cabal-devel mailing list cabal-devel@haskell.org http://www.haskell.org/mailman/listinfo/cabal-devel
