Hey all,
Paolo Giarrusso suggested that the Cabal project might look into
giving more people commit bits, ala
http://felixge.de/2013/03/11/the-pull-request-hack.html
I think we do need to give more commit bits. There's a sliding scale of
how extreme we can go:
1. We can adopt this wholesale: you PR, your GitHub profile checks
out, we give you bits.
2. If we accept your PR, we give you bits.
3. If we accept your PR for a new feature, we give you bits.
For (2), I trawled the commit history for 2016 and here's what I think
is all the commits from people without bits. I apologize if I missed
anyone (I just went through the commit list by hand.)
@thumphries
https://github.com/haskell/cabal/commit/ce2ffb24902816ab02f6c6b50921fb3a9a8b92aa
@sjakobi
https://github.com/haskell/cabal/commit/bb9501bc23914a50684f288bc88cf04747d69c32
@accraze
https://github.com/haskell/cabal/commit/11650b26ecf0ba95c3a7e747c0968735e906c3b0
@headprogrammingczar
https://github.com/haskell/cabal/commit/e9883dced04e6a16e25752cc8513ce26325b4b4b
https://github.com/haskell/cabal/commit/0252a0aed79e881d4f6210d9296216aef3c301d0
@randen https://github.com/haskell/cabal/commits/master?author=randen
@aisamanra
https://github.com/haskell/cabal/commit/6e2fca4314a01f07d520bc7b7669e70f70a231ce
@kolmodin
https://github.com/haskell/cabal/commit/0122e821825b875447f3844b349fba582fff39cf
@mightybyte
https://github.com/haskell/cabal/commit/ea01974be888d25ef918e7808aa6cf6b8aac1275
@gbaz
https://github.com/haskell/cabal/commit/c69dfb8209dc7bfd9abf2a7e494704db652073c9
@garetxe
https://github.com/haskell/cabal/commit/c72aa8dbb5a11fb4137bda62c9b7a99fb48b7649
@komadori
https://github.com/haskell/cabal/commit/1da9b3533e6a0fae8692fa0f4f532ea63d43ccc8
@mgsloan
https://github.com/haskell/cabal/commit/c10a4ca8c50290efc0b0ea65b34116ae165ccc9b
@lukexi
https://github.com/haskell/cabal/commit/5efc6341643e7fd98b33aea5a6ab96873d597787
@mpkh
https://github.com/haskell/cabal/commit/fcaf5d02947c5fd853ff69e2326e08f0082530c1
@pra85
https://github.com/haskell/cabal/commit/a69b0ea23b0f00be30933a1dbb63fbc4f1306c17
@tvestelind
https://github.com/haskell/cabal/commit/fe7b597542d57c74814620ed7a553e252b570ac7
@corngood
https://github.com/haskell/cabal/commit/4214572306205ad2c20943ef2b3aacbc912c45d3
@gelisam
https://github.com/haskell/cabal/commit/6b3457de66772d958fd5fe96066b08e93d0fb0c7
Why don't we give them all commit access! (If we want to do (1) also
look at the current PR queue.)
If people want, we could also formalize some more rules about the state
of master, e.g.,
- The Travis build must always be green. We should prioritize
adding more tests for things we care about. Look into regular
Hackage tests.
- PR all your changes (so that you can check that Travis is green),
try to get approval for big changes but BE BOLD.
Cheers,
Edward
_______________________________________________
cabal-devel mailing list
cabal-devel@haskell.org
http://mail.haskell.org/cgi-bin/mailman/listinfo/cabal-devel
