> -----Original Message----- > From: Robertson, Jason [mailto:[EMAIL PROTECTED]] > Sent: 28 December 2001 16:34 > To: '[EMAIL PROTECTED]' > Subject: Adding Authentication To Cactus >
[snip] > > Small Issues: > > - I didn't use java.security.Principal to hold the userId because it > didn't > seem to buy me much. This could easily be changed if necessary. > - Similarly, commons-httpclient has a UsernamePasswordCredentials object > which seems similar to my AbstractAuthentication Object minus the > configure > method, but I didn't get the code for it yet and can't verify exactly what > is does. > - Is there a base64Encode method somewhere that I could be using instead > of > pasting my own into the BasicAuthentication class? There is a class called Base64.java in httpclient which does what you need. As a matter of fact I am considering moving Cactus to httpclient for the HTTP connection. I'm just not sure whether to do it before applying your patch or after ... :-) It seems also that HttpClient currently does not support Basic or Form-based authentication. I have sent an email to the commons list to confirm this and asked whether it would be in-scope to implement it in HttpClient and then just reuse that in Cactus. > - I put the Abstract & BasicAuthentication objects in the util package, > only > so I wouldn't have to pull any other package into WebReqeust. If they > belong > somewhere more appropriate (and I'm betting they do), let me know. > As they are client side, I would prefer to have them in the client package. They could go in an authorization subpackage though. -Vincent -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
