Nick,

I just wanted to say welcome back between us! Thanks very much for your
latest commits. I have sent several emails about coding conventions,
etc. I wanted to say that it is not because I sent several emails that I
do not view your code positively. Quite the opposite! 

I think it is completely normal that I had several comments as we've
been changing our coding conventions and it is mostly undocumented.

We should definitely add Checkstyle rules like verifying that exceptions
in test cases are named "expected", etc, so that we don't need to
document our coding conventions in text but rather as part of the build
process.

Thanks again
-Vincent


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to