Hey, thanks. > etc. I wanted to say that it is not because I sent several emails that I > do not view your code positively. Quite the opposite!
That's fine, I always welcome constructive criticism. Or even informational criticism. I just wish we could pair. Email discussions are so inefficient! I guess that's the nature of open source! > We should definitely add Checkstyle rules like verifying that exceptions > in test cases are named "expected", etc, so that we don't need to > document our coding conventions in text but rather as part of the build > process. Yes, I agree. Is that possible within checkstyle? Nick On 6/22/03 2:52 AM, "Vincent Massol" <[EMAIL PROTECTED]> wrote: > Nick, > > I just wanted to say welcome back between us! Thanks very much for your > latest commits. I have sent several emails about coding conventions, > etc. I wanted to say that it is not because I sent several emails that I > do not view your code positively. Quite the opposite! > > I think it is completely normal that I had several comments as we've > been changing our coding conventions and it is mostly undocumented. > > We should definitely add Checkstyle rules like verifying that exceptions > in test cases are named "expected", etc, so that we don't need to > document our coding conventions in text but rather as part of the build > process. > > Thanks again > -Vincent > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
