Hi Kazuhito, I was trying to apply your patch but it's quite difficult. Do you think you could improve it in the following manner:
1/ send a cvs diff against CVS HEAD (unified diff) 2/ apply Cactus coding conventions as defined in http://jakarta.apache.org/cactus/participating/coding_conventions.html If 2/ is not right then the build fails as it's part of the automated checks. The best way is for you to run "ant dist" in jakarta-cactus/framework to see if your changes do not fail the build. Then what is really nice is to run the full release (ant release) to verify that tests still pass, etc. 3/ provide a diff for jakarta-cactus/documentation/docs/xdocs/changes.xml to include your changes. Thanks! -Vincent > -----Original Message----- > From: Kazuhito SUGURI [mailto:[EMAIL PROTECTED] > Sent: 26 February 2004 11:54 > To: [EMAIL PROTECTED] > Subject: FormAuthentication (bug #17933) [Re: Form Authentication is not > working in Weblogic Portal 7.0 SP4,need help] > > Hi, > > In article <[EMAIL PROTECTED]>, > Fri, 20 Feb 2004 11:56:29 +0900 (JST), > Kazuhito SUGURI <[EMAIL PROTECTED]> wrote: > suguri> I modified FormAuthentication while we (Ankur and I) were solving > this. > suguri> # please refer archive of cactus-users ML for detail. > suguri> > suguri> I believe the new FormAuthentication will be a solution for a > issue: > suguri> http://issues.apache.org/bugzilla/show_bug.cgi?id=17933 > suguri> > suguri> The code is appending to this message. > suguri> The code is modified from the one of the source release of Cactus- > 1.5. > > I didn't care about difference between 1.5 and 1.6dev, > so I modified little more. > > The code modified from the one of cactus-1.6dev20040225 is appending. > > > Followings are what I did to the original cactus-1.6dev20040225: > 1. Bug #17933 is fixed (I hope so) > (1) Get hostname from a HttpURLConnection instance of the first > connection, > which should contains set-cookie header field in its response, > then pass the hostname to the first argument of Cookie(String, String, > String) > constructor. > (2) Use WebRequest#addCookie(Cookie) instead of > WebRequest#addCookie(String, String) > > 2. New accessors are provided > (1) setExpectedPreAuthResponse(int)/getExpectedPreAuthResponse() > Set/get the expected HTTP response code for a request > to a restricted resource without authenticated principal. > The default is HttpURLConnection.HTTP_MOVED_TEMP. > > If the response code of the first connection is not what's expected, > authentication process will not be proceeded. > > (2) setExpectedAuthResponse(int)/getExpectedAuthResponse() > Set/get the expected HTTP response code for an authntication request > which should be succeeded. > The default is HttpURLConnection.HTTP_MOVED_TEMP. > > If the response code of the second connection is not what's > expected, > the authentication is considerd as failed. > > (3) setSessionCookieName(String)/getSessionCookieName() > Set/get the cookie name of the session. The default is "JSESSIONID". > > > Best Regards, > ---- > Kazuhito SUGURI > mailto:[EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
