Applied in CVS HEAD (I'm doing a nightly build now)! I've made some minor changes but mostly cosmetic (I've made the new getters private as I couldn't see why they would be useful for users).
Thanks so much Kazuhito! Note: For my own understanding, could you tell me briefly why it is sometimes required to call setExpected(Pre)AuthResponse to set an expected response different than 302? I thought it was standard? Thanks -Vincent > -----Original Message----- > From: Kazuhito SUGURI [mailto:[EMAIL PROTECTED] > Sent: 27 February 2004 05:16 > To: [EMAIL PROTECTED] > Subject: Re: FormAuthentication (bug #17933) > > Hi Vincent, > > First, I must apologize for my post at 26 Feb 2004 19:53:34 +0900. > I should read the participating page before I do. > > In article <[EMAIL PROTECTED]>, > Thu, 26 Feb 2004 14:41:52 +0100, > "Vincent Massol" <[EMAIL PROTECTED]> wrote: > vmassol> I was trying to apply your patch but it's quite difficult. Do you > think > vmassol> you could improve it in the following manner: > vmassol> > vmassol> 1/ send a cvs diff against CVS HEAD (unified diff) > vmassol> 2/ apply Cactus coding conventions as defined in > vmassol> > http://jakarta.apache.org/cactus/participating/coding_conventions.html > [snip] > vmassol> 3/ provide a diff for > vmassol> jakarta-cactus/documentation/docs/xdocs/changes.xml to include > your > vmassol> changes. > > I tried to do so, however, I cannot connect to the CVS server at this > moment. > My network administrator is closing the route. > > So, I applied changes against the source distributed as > jakarta-cactus-src-1.6dev20040225. > I hope the code FormAuthentication.java is same... > > Appendings are: > - the patch against the FormAuthentication.java > - the full source code of the new FormAuthentication.java > - action elements to be inserted in documentation/docs/xdocs/changes.xml. > > vmassol> If 2/ is not right then the build fails as it's part of the > automated > vmassol> checks. The best way is for you to run "ant dist" in > vmassol> jakarta-cactus/framework to see if your changes do not fail the > build. > vmassol> Then what is really nice is to run the full release (ant release) > to > vmassol> verify that tests still pass, etc. > > I confirmed "ant dist" in framework successfully finishes > with checkstyle-3.3. > > > Best Regards, > ---- > Kazuhito SUGURI > mailto:[EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
