The one concern I have is in auto_parse_manifest.c. line 186 is this: *len = (int) list_ln;
list_ln has been changed to Py_ssize_t to accommodate 64 bit systems. If you're casting it to an int do you for see an issue in the future? Sortof seems like this list realistically won't ever get this big but I'm asking. Jean Jan Damborsky wrote: > Hi, > > Could I please ask for reviewing the 2.4->2.6 & PEP8 changes > for AI client specific files ? > > Changes are covered by following bug: > 12391 Transition from Python2.4 to Python2.6 - AI client portion > > Thank you very much, > Jan > > > * Webrev > ======== > http://cr.opensolaris.org/~dambi/python-24-26/ > > * Testing > ========= > * platforms tested: x86, Sparc > * modules affected: > - AI client service discovery (ai_sd, ai_get_manifest) > - wrapper for AI manifest parser (ai_parse_manifest, auto_install) > > * procedures > - AI images based on build 125 created with changes incorporated > - 2.6 changes for AI manifest parser taken from Jack and applied > as well in order to be able to test the wrapper > > * scenarios tested along with results > [a] manifest obtained involving service discovery using mDNS - OK > [b] manifest obtained while bypassing mDNS - OK > [c] manifest without criteria (default) obtained - OK > [d] manifest with criteria (MAC or IPv4) obtained - OK > [e] obtained manifest successfully parsed by Automated Installer - OK > > Automated Installation then always failed when initiating the > transfer phase which is expected, since changes for Transfer > module were not integrated yet. > SMF log file for scenario [d] attached. > > > * pylint results: > ================= > http://cr.opensolaris.org/~dambi/pylint/ai_get_manifest.py.pylint.txt > http://cr.opensolaris.org/~dambi/pylint/ai_parse_manifest.py.pylint.txt > http://cr.opensolaris.org/~dambi/pylint/ai_sd.py.pylint.txt > > ai_get_manifest.py and ai_sd.py are not rated at 10 (8.87 and 9.87 > respectively), > as PEP8 changes are not high priority at this point. If there is an easy, > straightforward, non-invasive way to improve the ratio, the changes > are to > be accepted. Otherwise, separate bug is planned to be filed for > further PEP8 > specific changes. > > ------------------------------------------------------------------------ > > _______________________________________________ > caiman-discuss mailing list > caiman-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
