Hi Jean, jeanm wrote: > The one concern I have is in auto_parse_manifest.c. > line 186 is this: *len = (int) list_ln; > > list_ln has been changed to Py_ssize_t to accommodate 64 bit systems. > If you're casting it to an int > do you for see an issue in the future? Sortof seems like this list > realistically won't ever get this big but > I'm asking.
I don't foresee any problem with using 'int' here either. *len represents number of entries in array filled with the information extracted from AI manifest for group of elements with the same type (for instance it can be filled with sizes of partitions to be created). The reason why this casting is carried out is the consumer expecting number of elements to be returned as 'int'. Thank you for looking into this ! Jan