Jerry, src/brand/poststate: 47 zonename=$1 49 state=$3
src/brand/prestate: 47 zonename=$1 49 state=$3 src/brand/uninstall: 33 zonename=$1 These variables aren't used in the scripts. src/brand/uninstall: 78 if [ ! -z "$ZONEPATH_DS" -a ! -z "$CURRENT_GZBE" ]; then 144 if [ ! -z "$ZONEPATH_DS" -a ! -z "$CURRENT_GZBE" ]; then 161 if [ ! -z "$ZONEPATH_DS" ]; then Instead of using "! -z" wouldn't it be cleaner to use "-n" ? Other than that the webrev looks fine to me. Thanks Tim > [Apologies for any duplicates. I posted this on > pkg-discuss, but wanted to post it here as well > in case you don't follow that alias.] > > I need a code review for the initial zones/SNAP upgrade > integration. The webrev is at: > > http://cr.opensolaris.org/~gjelinek/zones_snap/ > > For reference, the spec is at: > > http://www.opensolaris.org/jive/thread.jspa?threadID=70461&tstart=0 > > Thanks, > Jerry > _______________________________________________ > caiman-discuss mailing list > caiman-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
