Jerry Jelinek wrote: > Tim, > > Thanks for looking this over. > > Tim Knitter wrote: >> Jerry, >> >> src/brand/poststate: >> 47 zonename=$1 >> 49 state=$3 >> >> src/brand/prestate: >> 47 zonename=$1 >> 49 state=$3 >> >> src/brand/uninstall: >> 33 zonename=$1 >> >> These variables aren't used in the scripts. > > These are just the standard parameters that we use in all > of the brand hooks, so I want to leave those alone. >
Maybe a comment would be beneficial then. >> src/brand/uninstall: >> 78 if [ ! -z "$ZONEPATH_DS" -a ! -z "$CURRENT_GZBE" ]; then >> 144 if [ ! -z "$ZONEPATH_DS" -a ! -z "$CURRENT_GZBE" ]; then >> 161 if [ ! -z "$ZONEPATH_DS" ]; then >> >> Instead of using "! -z" wouldn't it be cleaner to use "-n" ? > > I can change that. Thanks Tim > > Thanks again, > Jerry > _______________________________________________ > caiman-discuss mailing list > caiman-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
