Hi Karen.
I'm impressed by your fast work! Here are my comments:
transfermod.h: OK
transfer_mod.py:
1166: Please check that this option is used only for set-authority and
throw an exception if not.
transfer_defs.ph: OK
ict.py: OK.
DC_tm.py:
~97: Just so that I am clear, the call to DC_ips_refresh() is removed
here because it doesn't make any sense to do a refresh after unsetting
an authority. Is that correct? Or is it because another authority
(mirror, for example) is reinstated and would normally get a catalog
refresh but we don't want to do this?
144: I don't see the reason for differentiating preferred vs mirror
authority here. All that's being done is to validate that the authority
at the URL given has a viable repo. Whether that repo is being used as
a preferred repo or mirror shouldn't matter, right? If it indeed
doesn't make a difference, you can just call DC_ips_set_auth and get rid
of DC_ips_validate_auth.
386-389: Nit: Please add a space after the #.
396: It seems cleaner to me to unconditionally cleanup the temporary
directory used for validation, inside DC_ips_validate_auth(), since
you'll always be deleting this directory after ...validate_auth()
completes. This will allow you to eliminate the many calls to
cleanup_dir() in DC_populate_pkg_image().
Thanks,
Jack
Karen Tung wrote:
> Hi,
>
> Can I have 2 reviews for the changes to fix bug 4550 asap?
>
> 4550 'pkg uninstall SUNWslim-utils' fails with osol-0811-101a-rc1a.iso
> http://defect.opensolaris.org/bz/show_bug.cgi?id=4550
>
> webrev:
>
> http://cr.opensolaris.org/~ktung/4550_fix/
>
> Thanks,
>
> --Karen
> _______________________________________________
> caiman-discuss mailing list
> caiman-discuss at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
>
