I noticed in the diffs that that the line numbers on the old file don't 
match what's in the checked in code.  I am not sure why.

BC_tm.py:
99:  Could you please add doc comments for this def

def DC_ips_validate_auth
If I understand correctly, the main purpose of this function is that if 
pref_flag is set, the no-refresh flag for IPS occurs by default.   If 
so, could this be  added to the comment.  

232: looks like a bogus change.  Please add the period back.


The reset looks file to me.


-Sanjay


Karen Tung wrote:
> Hi,
>
> Can I have 2 reviews for the changes to fix bug 4550 asap?
>
> 4550 'pkg uninstall SUNWslim-utils' fails with osol-0811-101a-rc1a.iso
> http://defect.opensolaris.org/bz/show_bug.cgi?id=4550
>
> webrev:
>
> http://cr.opensolaris.org/~ktung/4550_fix/
>
> Thanks,
>
> --Karen
> _______________________________________________
> caiman-discuss mailing list
> caiman-discuss at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
>   


Reply via email to