Hi Alok, Thanks for the feedback. I'll make the changes you suggested as well as updating the docs.
Yes, I have tested the code. :) --Jens Alok Aggarwal wrote: > Hi Jens, > > On Mon, 17 Nov 2008, Jens Deppe wrote: > >> Please review the changes at >> >> http://cr.opensolaris.org/~jensd/4487_add_proxy_support/ >> >> Which address >> >> Auto Install can not be configured to use a proxy server >> http://defect.opensolaris.org/bz/show_bug.cgi?id=4487 > > auto_install.c: lines 608-617: One of the comments that > Dave made during the initial conversation was to make > this generic in that the HTTP_PROXY environment variable > could be used not only for the purposes of IPS but others > as well. With that in mind, I would suggest simply doing > a putenv(3C) of the HTTP_PROXY variable and not passing > the proxy value to the transfer module. > > auto_parse.c: line 453: remove the bit about accessing > the IPS repo since this proxy could be used for other > purposes as well. > > With the changes to auto_install.c, no changes should be > needed to the transfer module. > > Could you please also add the relevant information to > the AI design doc? It lives in the > hg.opensolaris.org/hg/caiman/caiman-docs repository. > > I'm assuming you tested these changes, am I correct? > > Thanks for doing this work, > Alok > _______________________________________________ > caiman-discuss mailing list > caiman-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
