I've made and tested the changes you suggested. The webrev is at the same location.
--Jens Alok Aggarwal wrote: > Hi Jens, > > On Tue, 2 Dec 2008, Jens Deppe wrote: > >> Hi Alok, >> >> I've made the changes you suggested. Please review here: >> >> http://cr.opensolaris.org/~jensd/4487_add_proxy_support/ > > auto_install.c: line 606: I think this would be clearer - > proxy_len = strlen("http_proxy=") + strlen(p) + 1; > proxy = malloc(proxy_len); > > auto_install.c: lines 607-608: These two lines could be > condensed into one - > snprintf(proxy, proxy_len, "%s%s", "http_proxy=", p); > > auto_install.c: line 611: the return value from putenv > should not be ignored. > > Looks fine otherwise. > > Alok > _______________________________________________ > caiman-discuss mailing list > caiman-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
