Sundar Yamunachari wrote: > Sarah Jelinek wrote: >> Hi all, >> >> I need 2 reviewers for the following changes: >> >> -Fix the slice info to include a separate swap slice. We were previously >> using a zvol for swap. >> -Fix the /etc/vfstab entry for the new swap device >> -Add enable_nwam and network_nwam.xml to SUNWadmc so that we can enable >> nwam during postinstall >> -Misc nits cleanups. >> >> The webrev is located at: >> >> http://anthrax.central/net/boora.central/brmnas/sjelinek/caiman/slim/webrev/ >> >> Apologies to those who are not Sun employees. This source isn't open yet >> so you can't review it. It should be open in the next week or so. >> >> Thank you in advance for your help, >> sarah >> _______________________________________________ >> caiman-discuss mailing list >> caiman-discuss at opensolaris.org >> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >> > Sarah, > > *usr/src/lib/liborchestrator/orchestrator_private.h: > * > 80 #define FOUR_GB_TO_MB 4098 > > - The value should be 4096 > Will fix. > *usr/src/lib/liborchestrator/perform_slim_install.c: > > *Line 1906: buf is not used in the function > setup_etc_vfstab_for_zfs_root(). You can remove buf. > Ok will do. > *usr/src/pkgdefs/SUNWadmc/prototype_com: > > *A nit. Move line 65 (f none sbin/enable_nwam) up after 60 (d none > sbin 0755 root sys) so that all sbin files are grouped together and > all var files are grouped together. > Certainly I can do that. I did it this way to "highlight" this in this pkg since it doesn't normally come from there. I imagine we will be removing it or moving this data to somewhere else eventually. But, if you want me to move this line I will.
thanks for the review, sarah *** > - Sundar
