On Tue, 14 Oct 2008, Jean McCormack wrote: > Well now I'm confused. > The check appears to only be true if the malloc fails. So what does this have > to do with the comment? > The comment is nice for the if at 820 so I wouldn't remove it though. Were we > actually seeing malloc fail?
We weren't seeing malloc fail. We hit a scenario where transfer_attr is intentionally NULL (LiveCD install) and so we let tcb_args->transfer_attr set to NULL as well (tcb_args->transfer_attr is NULL as part of the calloc() above). Alok
