Evan,
> Could you also add a test for providing a description to beCopy in > tbeadm.c so > this is easier to test? There is already a -d option in tbeadm and tbeadm interfaces directly with libbe so the libbe portion is already accounted for. > > As far as the changes go they look fine to me. > Thanks. Barbara, Could you verify the beadm man page changes in the webrev and let me know if you need assistance with adding this new beadm option and argument to the docs for Nov. Thanks Tim > Thanks! > -evan > > Tim Knitter wrote: >> In order to test the functionality that this code exposes, beadm has >> also been >> modified to make use of the new interface in libbe.c and is being >> addressed by >> this bug. A [-d description] opt & arg is beaing added to the beadm >> usage for create as follows: >> >> beadm create [-a] [-d description] [-e non-activeBeName | >> beName at snapshot] >> [-o property=value] ... [-p zpool] beName >> >> Please see the updated webrev that includes the changes to make the >> above happen. >> >> These changes have been successfully tested on bld99. >> >> Thanks >> Tim >> >> Tim Knitter wrote: >>> Caimaniacs, >>> >>> Please review the following simple change: >>> >>> 4054 beCopy() needs to take parameter for BE description >>> >>> WR: http://cr.opensolaris.org/~tsk/4054/ >>> B: http://defect.opensolaris.org/bz/show_bug.cgi?id=4054 >>> >>> This has been tested on bld99 with pkg(1) and beadm(1M). >>> >>> Thanks >>> Tim >>> _______________________________________________ >>> caiman-discuss mailing list >>> caiman-discuss at opensolaris.org >>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >> _______________________________________________ >> caiman-discuss mailing list >> caiman-discuss at opensolaris.org >> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >
