Thank you for the review Jan. I agree with all of you points and have addressed then as you suggest.
Updated webrev is at: http://cr.opensolaris.org/~joev/v2_bug3887_3988_4031_4047_4049_4090/ Thank you very much! Joe Jan Damborsky wrote: > Hi Joe, > > please see my comments below. > > Thank you, > Jan > > > lib/libict_pymod/ict.py > ----------------------- > > 144 ICT_PKG_RESET_UUIG_FAILED, > -> > 144 ICT_PKG_RESET_UUID_FAILED, > > 145 ICT_PKG_SEND_UUIG_FAILED, > -> > 145 ICT_PKG_SEND_UUID_FAILED, > > 1506 prerror('Failure. Returning: ICT_PKG_RESET_UUIG_FAILED') > 1507 return ICT_PKG_RESET_UUIG_FAILED > -> > 1506 prerror('Failure. Returning: ICT_PKG_RESET_UUID_FAILED') > 1507 return ICT_PKG_RESET_UUID_FAILED > > 1514 prerror('Failure. Returning: ICT_PKG_SEND_UUIG_FAILED') > 1515 return ICT_PKG_SEND_UUIG_FAILED > -> > 1514 prerror('Failure. Returning: ICT_PKG_SEND_UUID_FAILED') > 1515 return ICT_PKG_SEND_UUID_FAILED > > > lib/libict/ict.c > ---------------- > It seems that fix for 4049 is being applied only for LiveCD > case. I think that the same should be done for AI. > > cmd/slim-install/finish/install-finish > -------------------------------------- > I think that following ICT task is not applicable for AI > and might be removed: > > sa.append(icto.delete_misc_trees()) > > > > Joseph J VLcek wrote: >> Hi, >> >> Can two people please review the fixes for the following ICT bugs ? >> >> 3887 be_unmount() fails with 4040 at the end of b99 GUI installation >> http://defect.opensolaris.org/bz/show_bug.cgi?id=3887 >> >> 3988 installer should reset image UUID for opensolaris.org authority >> http://defect.opensolaris.org/bz/show_bug.cgi?id=3988 >> >> 4047 ICT add_sysidtool_sys_unconfig_entries is alway failing. >> http://defect.opensolaris.org/bz/show_bug.cgi?id=4047 >> >> 4090 ICT: keyboard_layout is failing >> http://defect.opensolaris.org/bz/show_bug.cgi?id=4090 >> >> 4049 sendmail complaining about hostname again >> http://defect.opensolaris.org/bz/show_bug.cgi?id=4049 >> >> 4031 no need to perform some ICT on an automated install >> http://defect.opensolaris.org/bz/show_bug.cgi?id=4031 >> >> The webrev is available at: >> http://cr.opensolaris.org/~joev/bug3887_3988_4031_4047_4049_4090/ >> >> Thank you very much, >> Joe >> >> - - - >> >> >> * The modules affected and tested: >> >> ICT - ict.py, libict and install-finish >> >> >> * Testing done for gui-install >> >> [1] Booted LiveCD image on live hardware HP Pavilion dv5000 >> [2] using ld_preload to load updated libict >> [3] using mount -F lofs to load updated ict.py >> [3] Installer run >> >> >> * Testing done for AI >> >> With help from Jan an AI image was built, AI was configured and a host >> was installed. The below results were confirmed on that host. >> >> >> * Results: >> >> + 3887 be_unmount() fails with 4040 at the end of b99 GUI installation >> >> Confirmed be_unmount error is not in install_log 10 out of 10 runs. >> >> + 3988 installer should reset image UUID for opensolaris.org authority >> >> Confirmed /var/pkg/cfg_cache UUID and send-uuid are updated. >> >> + 4047 ICT add_sysidtool_sys_unconfig_entries is alaway failing. >> >> Confirm ICT add_sysidtool_sys_unconfig_entries did not return an error. >> >> + 4090 ICT: keyboard_layout is failing >> >> Confirm ICT keyboard_layout did not return an error and confirmed >> LAYOUT= is written to /etc/default/kbd file. >> >> 4049 sendmail complaining about hostname again >> >> This fix is not applicable to AI. >> >> Confirmed sendmail error is not displayed on boot up and /etc/inet/hosts >> file has correct entries for ::1 and 127.0.0.1 >> >> 4031 no need to perform some ICT on an automated install >> >> Confirmed the correct list of ICT ran for a gui-install and AI >
