Alok, Thank you for the review feedback. I agree with all points.
I will update the changeset with the defect numbers just before I push and all coding issues have been resolved/tested/confirmed. Updated webrev is at: http://cr.opensolaris.org/~joev/v2_bug3887_3988_4031_4047_4049_4090/ Thank you very much! Joe Alok Aggarwal wrote: > Hi Joe, > > On Wed, 22 Oct 2008, Joseph J VLcek wrote: > >> Hi, >> >> Can two people please review the fixes for the following ICT bugs ? >> >> 3887 be_unmount() fails with 4040 at the end of b99 GUI installation >> http://defect.opensolaris.org/bz/show_bug.cgi?id=3887 >> >> 3988 installer should reset image UUID for opensolaris.org authority >> http://defect.opensolaris.org/bz/show_bug.cgi?id=3988 >> >> 4047 ICT add_sysidtool_sys_unconfig_entries is alway failing. >> http://defect.opensolaris.org/bz/show_bug.cgi?id=4047 >> >> 4090 ICT: keyboard_layout is failing >> http://defect.opensolaris.org/bz/show_bug.cgi?id=4090 >> >> 4049 sendmail complaining about hostname again >> http://defect.opensolaris.org/bz/show_bug.cgi?id=4049 >> >> 4031 no need to perform some ICT on an automated install >> http://defect.opensolaris.org/bz/show_bug.cgi?id=4031 >> >> The webrev is available at: >> http://cr.opensolaris.org/~joev/bug3887_3988_4031_4047_4049_4090/ > > install-finish: line 43: Change the comment to say > "Test to see if running in an automated install environment" > > install-finish: line 126: Change the comment to say > "Doing an automated install" > > install-finish: line 131: I think Jan already pointed out > that this ICT should not be run here. > > install-finish: line 155: Change the comment to say > "Doing a GUI install" > > Defect numbers need to be added to the changeset. > > Alok
