Hi William, Looks ok to me. As we discussed the comments on line 57 in td_be.c don't match the new functionality. Which you have fixed. The only other question I have is if you get what you think is a slice name, and it doesn't conform to anything that is available on the system, what happens to that data? Does it get discarded?
thanks, sarah *** William Schumann wrote: > TD had been using be_list() to find Solaris BEs. This necessitated > importing root pools before be_list() could assess them. > > Returning root pools to the pre-imported state, done with 'zpool > export', makes them unbootable until imported once more. Also, > importing them with a different name, done presently in TD, leaves them > unbootable later. > > To circumvent this problem, it was decided to parse the output of 'zpool > list', noting the slices found, and signaling that a root pool was found > on the corresponding disk. > > This code looks for disk names in the first column of the output, > verifying them in the main TD module, and passing some text to indicate > this to the user when the mouse hovers over the disk in screen 2 of the > installer. > http://defect.opensolaris.org/bz/show_bug.cgi?id=1021 > http://cr.opensolaris.org/~wmsch/bug-1021/ > _______________________________________________ > caiman-discuss mailing list > caiman-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss > >
