William Schumann wrote: > > > Ethan Quach wrote: >> William, >> >> Just some nits... >> >> td_be.c >> ------- >> 43 - Can you elaborate a little bit more here on what this function >> is really doing now. > I've added some additional explanation in the header.
thanks >> >> td_mg.c >> ------- >> 2273 - does this function need to be defined in td_lib.h or >> something? > I see no need for it. It's a static function. Why would I want to > define it in a header file? In the webrev, the "static" is removed so I thought it was being accessing elsewhere. >> >> 2298 - why is td_is_slice() prototyped in td_be.c:39 instead of a >> header? >> > Added to td_api.h still need to remove its declaration in td_be.c:39 thanks, -ethan > Refreshing webrev, > William >> >> Makefile >> -------- >> 93 - can this line just be removed? >> >> >> Rest look okay to me. >> >> -ethan >> >> >> >> >> William Schumann wrote: >>> TD had been using be_list() to find Solaris BEs. This necessitated >>> importing root pools before be_list() could assess them. >>> >>> Returning root pools to the pre-imported state, done with 'zpool >>> export', makes them unbootable until imported once more. Also, >>> importing them with a different name, done presently in TD, leaves >>> them unbootable later. >>> >>> To circumvent this problem, it was decided to parse the output of >>> 'zpool list', noting the slices found, and signaling that a root pool >>> was found on the corresponding disk. >>> >>> This code looks for disk names in the first column of the output, >>> verifying them in the main TD module, and passing some text to >>> indicate this to the user when the mouse hovers over the disk in >>> screen 2 of the installer. >>> http://defect.opensolaris.org/bz/show_bug.cgi?id=1021 >>> http://cr.opensolaris.org/~wmsch/bug-1021/ >>> _______________________________________________ >>> caiman-discuss mailing list >>> caiman-discuss at opensolaris.org >>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
