On Fri, 6 Mar 2009, Juergen Keil wrote: > 2009/3/6 Alok Aggarwal <Alok.Aggarwal at sun.com>: >> >> On Thu, 5 Mar 2009, Sanjay Nadkarni wrote: >> >>> lofiadm/main.c >>> 154: Though this is not something that you broke, could you fix the >>> format. >>> static int >>> gzip_compress >> >> Fixed. >> >>> 212: Comment explaining what the value 5 is. >> >> Changed this to LZMA_PROPS_SIZE which is self >> explanatory. >> >>> 230: ?Isn't there a #define for 8 ? What is it ? Also some explanation as >>> to why "t" is being incremented by 256 everytime. >> >> I've added a define for LZMA_UNCOMPRESSED_SIZE and >> also added a comment about the LZMA header layout. >> >> The updated webrev is here - >> >> http://cr.opensolaris.org/~aalok/lzma-lofi >> >> Please let me know if you have any further comments, >> I would like to file the RTI first thing tomorrow. > > lofiadm/main.c line 157: > > The local variable 'compress2p' must be declared static to avoid > dynamic linker lookup of the symbol "compress2" function for every > call to "gzip_compress": > > static int (*compress2p)(void *, ulong_t *, void *, size_t, int) = NULL;
Got it. Changed. Alok
