Karen Tung wrote: > Please review changes to the following bugs and RFE. > > Everybody is welcome to review the changes, as usual. > However, I would like to request somebody who > knows the Transfer Module well to review this > because most of the changes are in the Transfer Module. > > 2184 Transfer module 0-length file processing can be removed > http://defect.opensolaris.org/bz/show_bug.cgi?id=2184 > > 6690 transfer module should sort file list by location > http://defect.opensolaris.org/bz/show_bug.cgi?id=6690 > > 6701 support embedded content in live cd > http://defect.opensolaris.org/bz/show_bug.cgi?id=6701 > > webrev: > > http://cr.opensolaris.org/~ktung/March6/ > > I tested this by ensuring that nothing breaks for the normal case > of not having any extra content on the live CD. I also tested the > case where extra content is added to the live cd after the initial > CD image is created, and made sure that > those extra content don't end up in the installed image. >
General question that occurred to me: how big is the contents file that's generated? Just want to understand impacts on CD size. slimcd_gen_cd_content: It appears to me that most of the exclusions listed in the comments at 47 and the code at 98 are debris from some of the early iterations in the live CD during prototyping; in particular, find's for *.cpio *.bz2 *.7zip all come up empty on a build 108 global image. Also, shouldn't the .image_info file be excluded here? Out of curiosity, any particular reason you didn't use Python here, since it was basically a move of existing code? The reason I mention is that there's no shared definition of the contents file path between the code here and the transfer module, which would at least be easier to accomplish if you'd used Python for this half. transfer_mod.py: 465: "numbers and their corresponding file names" 489: " from file ". Should this perhaps be a warning that ends up in the installation log? Also, is there a reason not to add the same debug message at 533? 501: nit, please rewrap comments How did you verify that the installed image is correct after removing the 0-length code? Dave
