Hi Dave, Thanks for the code review. My responses are below.
Dave Miner wrote: > > General question that occurred to me: how big is the contents file > that's generated? Just want to understand impacts on CD size. The size of the file is 4.2K. > > slimcd_gen_cd_content: > > It appears to me that most of the exclusions listed in the comments at > 47 and the code at 98 are debris from some of the early iterations in > the live CD during prototyping; in particular, find's for > > *.cpio > *.bz2 > *.7zip > Yes, finds for *.cpio, *.bz2 and *.7zip are all empty. I kept those there because I was trying to move the logic of the existing transfer module code. I just remove it. It is less confusing that way. > all come up empty on a build 108 global image. Also, shouldn't the > .image_info file be excluded here? I will add it to the list here. I will also remove the ICT code that delete the file. > > Out of curiosity, any particular reason you didn't use Python here, > since it was basically a move of existing code? The reason I mention > is that there's no shared definition of the contents file path between > the code here and the transfer module, which would at least be easier > to accomplish if you'd used Python for this half. No particular reason. It's easier for me to do it in ksh since I know that better than Python, and it takes less lines of code to accomplish the same thing. If you think it is better to do it Python, I can change it. > > transfer_mod.py: > > 465: "numbers and their corresponding file names" Fixed. > > 489: " from file ". Should this perhaps be a warning that ends up in > the installation log? Also, is there a reason not to add the same > debug message at 533? I am changing the call to self.info_msg() so it will generate a warning in the install log. Also added same self.info_msg() call at 533 to print warning. > > 501: nit, please rewrap comments Fixed. > > How did you verify that the installed image is correct after removing > the 0-length code? All the "state" file for each package in /var/pkg/state/installed are 0 length files, so, they would point to the same file if the bug is still there. I tried "pkg uninstall" 2 different packages that are installed from the Live CD, and verified that both operation works. I also tried to use the system by using the web browser and installing additional packages. The updated webrev is at: http://cr.opensolaris.org/~ktung/March9/ Thanks, --Karen
