Ethan Quach wrote: > > > Jean McCormack wrote: >> Ethan Quach wrote: >>> Jean, >>> >>> usr/src/man/installadm.1m.txt needs to be updated >>> accordingly with these changes. Namely the 'start/stop' --> >>> 'enable/disable' change. >> There is a bug filed for this that Barb is the RE for. Number is: 7193 > > Ok. I've marked that a 200906 bug. > >>> >>> Should we create a new directory, usr/src/cmd/installadm/svc, >>> in the source tree to store these new service related files? >> Since ON doesn't do it that way and eventually we will be merging >> there I >> did it their way. It's less work in the long run. > > Ok. > >>> >>> Doesn't usr/src/cmd/installadm/setup-service.sh need to be >>> updated somewhere to enable the new system/install/server >>> service? Otherwise upon reboot, none of the enabled install >>> services get restarted, or am I missing something.. >> For this push, I was going to do a flag day that on the initial reboot >> after the pkg install the user needs to svcadm enable install/server. >> After the initial reboot everything works fine with this push. >> >> With the next round what you want is the plan. Or at least what I >> think you're wanting. >> That is, after the reboot the install/server service will be enabled >> if the >> user types svcadm enable install/server or if they installadm >> create-service. > > Is the next round encapsulated in a filed bug? There were some > other things we talked about that don't seem to be in this fix, so > just want to make sure we have everything we've planned > captured somewhere. There is a bug filed. I'll update it with more details once we agree on things tomorrow. > >> >>> >>> server.xml - what happened to the apache22 dependency? >>> I'm trying to look back in the discussion thread, and the last >>> note I see about this is that system/install/server would have >>> a required dependency on apache22. Did I miss something >>> in the thread? >> No. Friday was a hectic day and the info never made it to the thread. >> My bad. >> We don't really have a dependency upon the apache22 service. What we >> have >> a dependency upon is the apache process that we manually start up in >> create-image. >> That's why I added the start of the apache process in >> svc-install-server. > > Shouldn't you make sure a service was indeed turned on before > starting our instance of apache then? Or at least check the existence > of the $AI_HTTPD_CONF file? Same for the stop method I suppose. Actually the apache22 SMF service doesn't need to be on to run our apache process.
I agree that both should check for the existence of the httpd_conf file. I'll add the checks now. Jean Jean > > > thanks, > -ethan > >> >> Jean >> >> >>> >>> >>> thanks, >>> -ethan >>> >>> >>> Jean McCormack wrote: >>>> >>>> Can I please get a code review for 4488 >>>> >>>> CR: >>>> http://defect.opensolaris.org/bz/show_bug.cgi?id=4488 >>>> >>>> Webrev: >>>> http://cr.opensolaris.org/~jeanm/slim_4488/ >>>> >>>> Jean >>>> _______________________________________________ >>>> caiman-discuss mailing list >>>> caiman-discuss at opensolaris.org >>>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >>
