Jean McCormack wrote: >> >> Is the next round encapsulated in a filed bug? There were some >> other things we talked about that don't seem to be in this fix, so >> just want to make sure we have everything we've planned >> captured somewhere. > There is a bug filed. I'll update it with more details once we agree > on things > tomorrow.
ok. >> >>> >>>> >>>> server.xml - what happened to the apache22 dependency? >>>> I'm trying to look back in the discussion thread, and the last >>>> note I see about this is that system/install/server would have >>>> a required dependency on apache22. Did I miss something >>>> in the thread? >>> No. Friday was a hectic day and the info never made it to the >>> thread. My bad. >>> We don't really have a dependency upon the apache22 service. What we >>> have >>> a dependency upon is the apache process that we manually start up in >>> create-image. >>> That's why I added the start of the apache process in >>> svc-install-server. >> >> Shouldn't you make sure a service was indeed turned on before >> starting our instance of apache then? Or at least check the existence >> of the $AI_HTTPD_CONF file? Same for the stop method I suppose. > Actually the apache22 SMF service doesn't need to be on to run our > apache process. I meant the install services that we loop through at lines 46~55. If we didn't turn on any install services, there's no need to launch apache right at 65? Perhaps the existence or non-existence of the AI_HTTPD_CONF file is good enough, but I just didn't know whether we deliver a skeleton AI_HTTPD_CONF file or not. -ethan > > I agree that both should check for the existence of the httpd_conf > file. I'll add the checks > now. > > Jean > > Jean > > > > >> >> >> thanks, >> -ethan >> >>> >>> Jean >>> >>> >>>> >>>> >>>> thanks, >>>> -ethan >>>> >>>> >>>> Jean McCormack wrote: >>>>> >>>>> Can I please get a code review for 4488 >>>>> >>>>> CR: >>>>> http://defect.opensolaris.org/bz/show_bug.cgi?id=4488 >>>>> >>>>> Webrev: >>>>> http://cr.opensolaris.org/~jeanm/slim_4488/ >>>>> >>>>> Jean >>>>> _______________________________________________ >>>>> caiman-discuss mailing list >>>>> caiman-discuss at opensolaris.org >>>>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >>> >
