Ethan, *usr/src/cmd/installadm/create-client.sh:
*199: Just a nit... The comment doesn't sound right. *usr/src/cmd/installadm/installadm-common.sh:* 102: Check whether ipaddr is non-null after line 98. If it is null, this will result in syntax error. 122: Validate ipaddr and netmask 123: Can you add some comment to indicate what bitwise_and does and why you are doing it? *usr/src/cmd/installadm/installadm.c* Are these changes part of your bug fix? It looks like saving service data is moved up. *usr/src/cmd/installadm/setup-dhcp.sh* 63: Make sure that IP address is non-null - Sundar Ethan Quach wrote: > Can I get a review for these blockers. > > > Webrev: > ------------ > http://cr.opensolaris.org/~equach/webrev.5589.7797.7226/ > > Defects: > ------------ > http://defect.opensolaris.org/bz/show_bug.cgi?id=5589 > http://defect.opensolaris.org/bz/show_bug.cgi?id=7797 > http://defect.opensolaris.org/bz/show_bug.cgi?id=7226 > > > > thanks, > -ethan > > _______________________________________________ > caiman-discuss mailing list > caiman-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://mail.opensolaris.org/pipermail/caiman-discuss/attachments/20090406/ccb5ae0c/attachment.html>
