Hi Ethan,

Sundar mentioned that some of the arguments passed in were not being validated 
and it looks like generally throughout these scripts we're not validating 
what's 
passed in. Would it be of value to at least change this for the functions we 
touch?

Other than that it looks fine to me.

Thanks for getting this done and for the explanation on bitwise_and()! :-)

-evan

Ethan Quach wrote:
> Can I get a review for these blockers.
> 
> 
> Webrev:
> ------------
> http://cr.opensolaris.org/~equach/webrev.5589.7797.7226/
> 
> Defects:
> ------------
> http://defect.opensolaris.org/bz/show_bug.cgi?id=5589
> http://defect.opensolaris.org/bz/show_bug.cgi?id=7797
> http://defect.opensolaris.org/bz/show_bug.cgi?id=7226
> 
> 
> 
> thanks,
> -ethan
> 
> _______________________________________________
> caiman-discuss mailing list
> caiman-discuss at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss


Reply via email to