Hi Dave,

Comments below...
> Caimaniacs,
>
> Please review the fixes for
>
> 6440 Build 106 installer fails to start in 512 MB environment
> 7975 LiveCD still has old branding - desktop background - in B111
>
> (I've dispensed with links to the above here as the recent webrev 
> updates now include d.o.o linkage in the webrev).
>
> webrev for which may be found at:
>
> http://cr.opensolaris.org/~dminer/slim_6440/
>
> This has been tested extensively on x86, both in live CD and x86 AI 
> installations, including in domU's (thanks to John Levon).  I'm still 
> in the process of testing SPARC, but since it's supposed to be a no-op 
> for SPARC, do not anticipate issues.
DC_defs.py:
-The base path for both sparc and x86 is /boot, so why not define a 
BR_BASEPATH, then go from there in terms of defining the 
BR_FILENAME_SPARC, etc...

For example:
BR_BASEPATH = "/boot"
BR_FILENAME_SPARC = BR_BASEPATH + "boot_archive"
BR_X86_FILENAME = "x86.microroot"
BR_FILENAME_X86 = BR_BASEPATH + "/"  + BR_X86_FILENAME
...

ai_sparc_image.xml:
-line 501 you pass in "all" to bootroot_archive.py, but in 
bootroot_archive.py you check for is_sparc. Why do you pass in "all" 
then check for is_sparc, if it is_sparc why not pass in 'sparc'?

I can see that you pass in 'all' in ai_x86_image.xml as well which 
passes through to these lines:
> 267 else:
>  268         BR_ARCHFILE = PKG_IMG_MNT_PT + BR_FILENAME_ALL
>  269         BR_BUILD = BR_MASTER
>  270         strip_archive = False
I assume you did this just to be consistent in the xml templates?

bootroot_archive.py:
-Why do we add 20% to smaller archives for padding?

slim_cd_generic_live.xml:
-line 137, why the change to sendmail from ndp?

transfer_mod.py:
-line 446, why did you move the list of files to cpio to /tmp rather 
than keeping it in self.dst_mntpt?

-General question.. what is the memory requirement with your changes? < 
512MB but do you have a sense of how close this is to the 512MB limit?

thanks,
sarah
****
>
> Dave
> _______________________________________________
> caiman-discuss mailing list
> caiman-discuss at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss


Reply via email to