Evan,
These are mostly just nits ...
65 - Can't you use INSTALLED_ROOT_DIR instead of defining INST_MNTPT?
566 - "Installer build version: " ?
1584 - "Target build version: " ?
2970 - "from" -> "of an image root path using the output of"
2973 - This sounds like you already know who's going to be calling
this function, and with what.
Suggest: "The image root path to check"
3014,3021,3022 - need (void)
3032 - Does it have to be two lines? Why not just "%s %s\n"
thanks,
-ethan
Evan Layton wrote:
> I need two reviewers for:
>
> 7838 Log installer build number and installed software build number in
> install_log
> http://defect.opensolaris.org/bz/show_bug.cgi?id=7838
>
> and
>
> 6810 AI image missing D-Trace toolkit
> http://defect.opensolaris.org/bz/show_bug.cgi?id=6810
>
> Webrev:
>
> http://cr.opensolaris.org/~evanl/7838/
>
>
> I've tested this with both an AI and slim CD image and get the proper
> output.
>
> In the log you'll see lines similar to:
> <OM Apr 15 19:14:09> Install running on:
>
> FMRI: pkg:/entire at 0.5.11,5.11-0.111:20090331T092149Z
>
> and
>
> <OM Apr 15 19:40:42> System installed with:
>
> FMRI: pkg:/entire at 0.5.11,5.11-0.111:20090415T070733Z
>
>
> Thanks,
> -evan
> _______________________________________________
> caiman-discuss mailing list
> caiman-discuss at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
