hi Jan, A few comments/questions:
setup-sparc.sh: line 242: Would we ever have case where the service name isn't specified in install.conf? Seems like this check is unnecessary. line 247: This might be better worded something like: "To enable $svc_name for Sparc clients not explicitly associated with another Sparc service you must override the system /etc/netboot/wanboot.conf as follows:" setup-service.sh: line 281: How is this checking to see if the /etc/netboot/wanboot.conf file refers to the specific wanboot.conf of the service we are deleting? thanks, sarah **** > Hi, > > could I please ask two people for reviewing changes for following > blocker ? > > 8262 'installadm create-service' shouldn't overwrite > /etc/netboot/wanboot.conf for Sparc, but notify user instead > > webrev: > http://cr.opensolaris.org/~dambi/bug-8262 > > Thank you very much, > Jan > > > modules affected: > ----------------- > * installadm tools (Sparc platform) > > testing done - please see attached test procedures > --------------------------------------------------- > > ------------------------------------------------------------------------ > > _______________________________________________ > caiman-discuss mailing list > caiman-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
