Jan, *usr/src/lib/libti/ti_dm.c**:
*491: If realloc fails what happens to the original pt_orig before the realloc? Do you want to save the pointer and free it in case realloc fails? 492: Need to close the pt_file before returning. 411: npart is uint_t where as npart_orig is int - Sundar jan damborsky wrote: > Hi Sundar, Niall > > could I please ask you for reviewing the fix for following CR ? > > 82 Installer crashes after 3 seconds > http://defect.opensolaris.org/bz/show_bug.cgi?id=82 > > * Webrev: > http://cr.opensolaris.org/~dambi/bug-82/ > > * modules affected > - GUI > - orchestrator > - TI > > Please see below for list of modules tested > and testing procedures carried out. > > Thank you, > Jan > > > * tested binaries > o liborchestrator.so.1 > o libti.so.1 > o gui-install > > * following partition configuration tested > (they were originally causing installer to crash) > > [i] 2nd primary partition not used > Device Boot Start End Blocks Id System > /dev/sda1 * 1 3952 31744408+ 7 HPFS/NTFS > /dev/sda3 5259 18666 107699760 f W95 Ext'd (LBA) > /dev/sda4 18667 19457 6353707+ 83 Linux > /dev/sda5 5259 18525 106567146 7 HPFS/NTFS > /dev/sda6 18526 18666 1132551 82 Linux swap / Solaris > > Installer successfully utilized free 2nd primary partition > (/dev/sda2) for creating Solaris2 partition > > [ii] 1st primary partition not used > Device Boot Start End Blocks Id System > /dev/sdb2 1300 1499 1606500 83 Linux > /dev/sdb3 1 1000 8032468+ 83 Linux > /dev/sdb4 1500 2000 4024282+ 5 Extended > > Installer successfully utilized free 1st primary partition > (/dev/sdb1) for creating Solaris2 partition > > [iii] 2nd & 4th primary partitions not used > Device Boot Start End Blocks Id System > /dev/sda1 * 1 3952 31744408+ 7 HPFS/NTFS > /dev/sda3 5259 18666 107699760 f W95 Ext'd (LBA) > /dev/sda5 5259 18525 106567146 7 HPFS/NTFS > /dev/sda6 18526 18666 1132551 82 Linux swap / Solaris > > Installer successfully utilized free 2nd primary partition > (/dev/sda2) for creating Solaris2 partition > > * regression testing done: > - whole disk path on empty disk > - whole disk path on disk with existing partitions > - new Solaris2 partition created on empty disk > - new Solaris2 partition created on disk containing > existing partitions > - Solaris2 partition created by changing type of > existing primary partition > > -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://mail.opensolaris.org/pipermail/caiman-discuss/attachments/20080617/c7a3bbaf/attachment.html>
