Hi Jan,

I review the code changes to the GUI code:
usr/src/cmd/gui-install/src/orchestrator-wrappers.c

The changes are fine but I have the following 2 nits:
The variable "highest" in the original code was named 
as such based on the broken assumption that there would
be no gaps in partition ID numbering so the new partition
ID would be the highest + 1. It's a bit misleading now.
The variable should be renamed to make it more indicative
of what it represents ie. the first unused partition ID.

Also, the g_debug() statement does not need a "\n".

Otherwise, looks fine to me.

Thanks,
Niall.
--
This message posted from opensolaris.org

Reply via email to