All,
I have finally updated the webrev for the list changes. I believe
that I have addressed the concerns that were related to the list
and not something missing elsewhere. When these other issues are
resolved I will update list. I will follow up on Monday by filing
bugs against these other issues.
The code was checked by 'hg nits' and pylint using the install.pylintrc
file sent out by Jean. hg nits did not find anything to correct. The
only complaints pylint found were:
C0302 - Too many lines in module (%s)
E0602 - Undefined variable '_' -- defined via gettext __init__
The new webrev is at:
http://cr.opensolaris.org/~johnfisc/list
These changes are for the installadm list subcommand fix and will
address:
4330 installadm list should show which server provide the install
services.
4113 nice to have an option to show what service the client is using
4298 installadm list -n should give different output if there is no
custom manifest
4597 installadm list: expect usage statement when giving service name
without "-n" flag.
4646 list: showing added manifest for a non running service.
5300 list: does not show informational message for non running service.
8496 list: no verbiage indicating that a service does not exist when a
non-existent service is given.
8529 'installadm list' command lists same service three times
6811 list: should have similar output between list and list -n
8015 list-manifests output is hard to read
9094 installadm list: prints colons for empty MAC fields, and doesn't
account for colons or periods in MAC field's width
4175 install list error slips out
13096 installadm man page should be converted to nroff
12808 Need to update man page and documentation for create-client
Barbara has reviewed the changes to the man page already.
I really appreciate everyone's help in the review process.
Thanks,
John
John Fischer wrote:
> Ethan, Clay and Sundar,
>
> When you get a chance can you review my webrev at:
>
> http://cr.opensolaris.org/~johnfisc/list
>
> These changes are for the installadm list subcommand fix and
> will address:
>
> 4330 - installadm list should show which server provide the install
> services.
> 4113 - nice to have an option to show what service the client is
> using
> 4298 - installadm list -n should give different output if there is
> no custom manifest
> 4597 - installadm list: expect usage statement when giving service
> name without "-n" flag.
> 4646 - list: showing added manifest for a non running service.
> 5300 - list: does not show informational message for non running
> service.
> 8496 - list: no verbiage indicating that a service does not exist
> when a non-existent service is given.
> 8529 - 'installadm list' command lists same service three times
> 6811 - list: should have similar output between list and list -n
> 8015 - list-manifests output is hard to read
> 9094 - installadm list: prints colons for empty MAC fields, and
> doesn't account for colons or periods in MAC field's width
> 4175 - install list error slips out
>
> The changed and added files are:
>
> usr/src/cmd/installadm/Makefile
> usr/src/pkgdefs/SUNWinstalladm-tools/prototype_com
> usr/src/cmd/installadm/installadm.c
> usr/src/cmd/installadm/installadm.h
> usr/src/cmd/installadm/list.py
>
> These changes also include a change to the Makefile and prototype_com
> file for the delete_service and delete_client to be consistent with
> the other python scripts within the /usr/lib/installadm directory.
>
> The remote service listing is being postponed due to a timing issue
> with multiple remote services that grows with the number of services
> within the domain.
>
> Thanks,
>
> John
> _______________________________________________
> caiman-discuss mailing list
> caiman-discuss at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
