John, just two issues to address below: >> delete_service.py ... >> 222ff: This logic isn't quite the same as what in.tftpd uses when -s is >> specified (which is the normal and recommended case). If -s is used and >> the directory doesn't exist the the tftp service should go to >> maintenance. I think you can simplify on this basis. > > I am going to assume that this will be fixed when defect 13123 is resolved. >
This seems orthogonal to me; fixing 13123 just involves where the data is obtained from, not the semantics, so I think you can change here now. >> list.py ... >> 560: how would this condition be the case? Should we do something >> stronger than just skip it? > > It shouldn't happen at all. If it does then there is something wrong > within the SMF service. I will send a message to stderr and exit. I > have code elsewhere as well and will treat the issue the same way. > OK; the comment at 778 is now incorrect, though. Dave
