Hi Text Installer maniacs.. below is my review for the some of the 'profile' code, and an additional comment on libtarget_pymod/tgt.c. I will finish the profile code on Sunday and send final comments then. I just ran out of time to finish it today. And, I need to get going for the day.
thanks, sarah ***** libtarget_pymod/tgt.c: > 265 //Py_DECREF(unknown); /* get rid of extra ref */ I would think we would need this since you have a reference to 'unknown' left? osol_install/profile/*: disk_info.c: > 416 g = tgt.Geometry(blocksz=self.blocksz, cylsz=self.cylsz) maybe the variable name could be 'geo' or something more descriptive? -The classes: FileSize PartitionInfo SliceInfo Don't appear to be nested in the DiskInfo class. Just wondering why you have all of these in the same file? -I assume when you don't use the property() method in this file for getters/setters it is because they are more complicated setter/getter methods? For example, the get_extended_partition() method. Just wondering. -You are using 1024 for KB in the text installer. Is the GUI the same? It didn't used to be. > 327 min_gap_size = 1024**3 # 1 GB Couldn't you define the size, as you did in the FileSize class and not hard code it here?
