On 12/22/09 11:45 AM, Keith Mitchell wrote: > Hi Dave, > > Thanks for the review. Comments below. > > - Keith > > Dave Miner wrote: >> Keith Mitchell wrote: >>> Hi Glenn and all other reviewers, >>> >>> I have posted an updated webrev at: >>> http://cr.opensolaris.org/~kemitche/text_v2/ >>> >> >> My comments on the Image/Distro-const and Packaging/Makefiles, plus a >> couple of other random things, are below. >> >> Dave >> >> usr/src/Makefile.master, 110 and usr/src/Targetdirs, 82: for >> consistency with other components, I'd suggest text_install > > gui-install, ai-webserver, auto-install, install-tools, slim-install - I > think using text-install as the directory name under usr/src/cmd is more > consistent. The folders/files that drop into python directories use an > underscore, and are consistent in that respect. >
The overall inconsistency between source dir names and installed names bothers me, but you're at least consistent with it, so OK. OK with other responses. Dave
